A general remark - why a simple code, like in Geant4GDMLBuilder is not a method ?
That class doesn't keep a state.

def build_gdml_from_json( world_json: Optional[dict]) -> str

should do the job as well.

The same applies to MaterialCollector and other classes.

The code looks very weird and not pythonic :/

A general remark - why a simple code, like in Geant4GDMLBuilder is not a method ? That class doesn't keep a state.

def build_gdml_from_json( world_json: Optional[dict]) -> str

should do the job as well.

The same applies to MaterialCollector and other classes.

The code looks very weird and not pythonic :/

Fair enough, on daily basis i write in java so the code could have some OOP similarities,. Do you want more method base approach ?

A general remark - why a simple code, like in Geant4GDMLBuilder is not a method ? That class doesn't keep a state.
def build_gdml_from_json( world_json: Optional[dict]) -> str
should do the job as well.
The same applies to MaterialCollector and other classes.
The code looks very weird and not pythonic :/

Fair enough, on daily basis i write in java so the code could have some OOP similarities,. Do you want more method base approach ?

Yes, Python is not a Java. I ran quick copilot survey on this code which generated guidelines which I strongly support:

In python we don't care much about private/public stuff (everything is public anyway). We don't inherit much as well.

What requires more attention that many methods/function in this code have way too many lines and should be splitted into smaller pieces.

Can you convert all of your codes into simple functions, with meaningful names, which do not modify its arguments. Good idea would be also to completely get rid of classes. We don't need a polymorphism here, nor any need to keep a state of some object. The logic here is simple transformation from one state to another which can be achieved by set of testable functions scattered among couple of modules.

we have only one class that is absolutely needed, ( extends class parser as every other converter )

@Ciorolla any news ?

It looks much more readable now, I can now proceed with E2E testing on yap-dev.